[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/PythagoreanTriples#38454
Closed
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor(NumberTheory): golf Mathlib/NumberTheory/PythagoreanTriples#38454yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Mathlib/NumberTheory/PythagoreanTriples#38454yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
yuanyi-350
added
codex
PR summary e18244a4f1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.This script lives in the
|
github-actions
Bot
added
the
t-number-theory
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
|
Collaborator
Author
|
!bench |
14 tasks
|
Benchmark results for dcb553d against e18244a are in. No significant results found. @yuanyi-350
No significant changes detected. |
Contributor
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by MichaelStollBayreuth. |
mathlib-triage
Bot
added
the
maintainer-merge
Vierkantor
approved these changes
Apr 27, 2026
Contributor
Vierkantor
left a comment
Vierkantor
left a comment
There was a problem hiding this comment.
The benchmark results are positive, so:
bors r+
Comment on lines
-155
to
+150
| simp only [hz, dvd_zero] | ||
| simp [h0, hz] |
Contributor
There was a problem hiding this comment.
This change by itself would not be worth including. I have a weak preference towards simp at the end of tactic blocks so it is not a regression, but it is not much clearer either.
Since it is included in a set of good changes, it can lift along.
mathlib-triage
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 27, 2026
#38454) - simplifies the `Int.gcd x y = 0` branches in `gcd_dvd`, `normalize`, and `classified` using `Int.gcd_eq_zero_iff` - shortens the zero case in `normalize` to a direct `simpa` from `PythagoreanTriple.zero` Extracted from #38144 [](https://gitpod.io/from-referrer/)
](https://gitpod.io/from-referrer/){kind=link}
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
Bot
changed the title
Mathlib/NumberTheory/PythagoreanTriplesMathlib/NumberTheory/PythagoreanTriples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Int.gcd x y = 0branches ingcd_dvd,normalize, andclassifiedusingInt.gcd_eq_zero_iffnormalizeto a directsimpafromPythagoreanTriple.zeroExtracted from #38144